Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armstrong-numbers exercise #698

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add armstrong-numbers exercise #698

merged 1 commit into from
Nov 15, 2024

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Nov 13, 2024

I don't know if this is the right approach for this exercise. Does the code need some type checking?

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure type indicators would be helpful here, either. Armstrong technically should work with other base numbers other than base 10.

@glennj
Copy link
Contributor Author

glennj commented Nov 15, 2024

Just because of the use of bignum in the tests, the example solution relies on the parameter being a Math::BigInt. Ah well, TDD.

@kotp kotp merged commit dbfdd9f into exercism:main Nov 15, 2024
21 checks passed
@kotp
Copy link
Member

kotp commented Nov 15, 2024

Let's get it in and adjust after getting some information in terms of mentoring/review of the exercise.

@glennj glennj deleted the armstrong branch November 16, 2024 01:05
@m-dango
Copy link
Member

m-dango commented Nov 16, 2024

I will have another look at this later, but I may make some modifications such as adding packages-and-modules as a prerequisite, or using explicit BigInt objects as the argument in the tests (because it won't be obvious in the web UI that objects are being passed in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants