Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests in runtests.jl for perfect-numbers #716

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

depial
Copy link
Contributor

@depial depial commented Mar 27, 2024

Adds six tests which require the functions to return false, supplementing the previous testing whose inputs returned true, resolving this issue

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ErikSchierboom
Copy link
Member

Thanks for this! I'll let @cmcaine take a quick look too, but LGTM!

@ErikSchierboom ErikSchierboom merged commit 92d4b26 into exercism:main Mar 29, 2024
11 checks passed
@ErikSchierboom
Copy link
Member

Merged, thanks!

@depial depial deleted the single-change branch March 29, 2024 11:29
@cmcaine
Copy link
Contributor

cmcaine commented Apr 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants