Add resistor-color-duo #703
Conversation
|
|
||
| @testset verbose = true "Resistor Color Duo" begin | ||
| @testset "Brown and black" begin | ||
| @test colorcode(["brown", "black"]) == 10 |
There was a problem hiding this comment.
It's still weird that this and the trio exercise pass in a vector rather than separate arguments. Is this related to the learning objectives for the exercise?
There was a problem hiding this comment.
As far as I know, that was by design. Notably, Haskell does separate arguments (see https://github.com/exercism/haskell/blob/main/exercises/practice/resistor-color-duo/src/ResistorColors.hs and https://github.com/exercism/haskell/blob/main/exercises/practice/resistor-color-trio/src/ResistorColors.hs). However since we already use a vector in resistor-color-trio, it makes sense to do the same here for consistency.
There was a problem hiding this comment.
Sure, maybe it'll help people who haven't worked out how to index collections yet or something.
There was a problem hiding this comment.
Should resistor-color-trio be updated then? You'll break solutions, but the whole resistor color series will be consistent on how they handle arguments.
There was a problem hiding this comment.
No, I don't think so. I was saying "sure let's do the same as trio for consistency".
Co-authored-by: Colin Caine <cmcaine@gmail.com>
|
|
||
| @testset verbose = true "Resistor Color Duo" begin | ||
| @testset "Brown and black" begin | ||
| @test colorcode(["brown", "black"]) == 10 |
There was a problem hiding this comment.
Sure, maybe it'll help people who haven't worked out how to index collections yet or something.
We could show the mathematical approach I used or a reduce-based approach. If we switch this exercise to use two separate arguments for the colors, the reduce approach is still worthwhile but not as "clean" since we'd need to create a collection to then reduce. Otherwise, I don't think we need approaches for how to retrieve the individual band values since that'd be covered by resistor-color. |
Related to #675. I'm moving this exercise in the config before resistor-color-trio. That lumps the three resistor color exercises together so the student can find the next one on the website easily.