Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two-fer exercise #700

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Add two-fer exercise #700

merged 1 commit into from
Feb 18, 2024

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Feb 5, 2024

Related to #675

Copy link
Contributor

@cmcaine cmcaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as eliuded's eggs. Seems fine. Would be nice to have a brief approaches file explaining how to solve it and naming the concepts (default values/optional arguments and string interpolation) and linking to their docs in the manual.

https://docs.julialang.org/en/v1/manual/functions/#Optional-Arguments
https://docs.julialang.org/en/v1/manual/strings/#string-interpolation

@BNAndras
Copy link
Member Author

BNAndras commented Feb 8, 2024

Sure, I'd add a string concatenation approach for completeness, highlighting that interpolation is often more readable.

@cmcaine
Copy link
Contributor

cmcaine commented Feb 18, 2024

For this and the other exercises, do you want me to merge them as-is or would you like to contribute approaches files first? No rush.

@BNAndras
Copy link
Member Author

You can merge them. I’m still planning on getting to them.

@cmcaine cmcaine merged commit faca052 into exercism:main Feb 18, 2024
11 checks passed
@BNAndras BNAndras deleted the add-twofer branch February 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants