Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test reporting workflow #22

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix test reporting workflow #22

merged 2 commits into from
Apr 11, 2024

Conversation

Mai-Lapyst
Copy link
Contributor

Fixes not-working test result publishing similar to #21 by reverting parts of f478c00

@Mai-Lapyst Mai-Lapyst force-pushed the fix-test-reports branch 4 times, most recently from b7da531 to 8774489 Compare April 11, 2024 14:13
@cclauss
Copy link
Contributor

cclauss commented Apr 11, 2024

https://github.com/dorny/test-reporter?tab=readme-ov-file#recommended-setup-for-public-repositories

Workflows triggered by pull requests from forked repositories are executed with read-only token and therefore can't create check runs. To workaround this security restriction, it's required to use two separate workflows

@cclauss cclauss mentioned this pull request Apr 11, 2024
Closed
@Mai-Lapyst
Copy link
Contributor Author

https://github.com/dorny/test-reporter?tab=readme-ov-file#recommended-setup-for-public-repositories

Workflows triggered by pull requests from forked repositories are executed with read-only token and therefore can't create check runs. To workaround this security restriction, it's required to use two separate workflows

Yeah okay then github changed things on their end I wasn't aware of. If you could review it quick it would be good to merge.

cclauss
cclauss reviewed Apr 11, 2024
View reviewed changes
@Mai-Lapyst @cclauss
Document why to use upload-artifact v3 instead of v4
787119a 
Co-authored-by: Christian Clauss <cclauss@me.com>
@Mai-Lapyst Mai-Lapyst merged commit 3389cda into exercism:main Apr 11, 2024
2 checks passed
@Mai-Lapyst Mai-Lapyst deleted the fix-test-reports branch April 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mai-Lapyst @cclauss