From 2f59bf94e95b7f32f43af27fde00f86ae56ad690 Mon Sep 17 00:00:00 2001 From: fap <459631+fapdash@users.noreply.github.com> Date: Tue, 18 Jun 2024 23:04:07 +0200 Subject: [PATCH 1/4] grade-school: Remove unused function from example.el --- exercises/practice/grade-school/.meta/example.el | 3 --- 1 file changed, 3 deletions(-) diff --git a/exercises/practice/grade-school/.meta/example.el b/exercises/practice/grade-school/.meta/example.el index 765ab6d7..9dc2f7c0 100644 --- a/exercises/practice/grade-school/.meta/example.el +++ b/exercises/practice/grade-school/.meta/example.el @@ -28,9 +28,6 @@ (defun grade (school grade) (gethash grade (school-roster school))) -(defun set-grade (school grade newval) - (puthash grade (sort newval #'string<) (school-roster school))) - (provide 'grade-school) ;;; grade-school.el ends here From 0448250ff83c464e0efd507b1324390a066539c8 Mon Sep 17 00:00:00 2001 From: fap <459631+fapdash@users.noreply.github.com> Date: Tue, 18 Jun 2024 23:04:41 +0200 Subject: [PATCH 2/4] grade-school: Fix stubs arguments - use school instead of students in line with exercise description and `example.el` - fix `add` function stub missing two arguments - fix `grade` function stub having wrong order of arguments --- exercises/practice/grade-school/grade-school.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exercises/practice/grade-school/grade-school.el b/exercises/practice/grade-school/grade-school.el index 784cae79..702f04cc 100644 --- a/exercises/practice/grade-school/grade-school.el +++ b/exercises/practice/grade-school/grade-school.el @@ -5,13 +5,13 @@ ;;; Code: -(defun roster (students) +(defun roster (school) (error "Delete this S-Expression and write your own implementation")) -(defun add (students) +(defun add (school name grade) (error "Delete this S-Expression and write your own implementation")) -(defun grade (desired-grade students) +(defun grade (school grade) (error "Delete this S-Expression and write your own implementation")) From 480c8ad7bee2cb277a7cb9a949589873145233aa Mon Sep 17 00:00:00 2001 From: fap <459631+fapdash@users.noreply.github.com> Date: Tue, 18 Jun 2024 23:07:35 +0200 Subject: [PATCH 3/4] grade-school: Fix flycheck warnings in tests --- exercises/practice/grade-school/grade-school-test.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/exercises/practice/grade-school/grade-school-test.el b/exercises/practice/grade-school/grade-school-test.el index e173b439..1d275368 100644 --- a/exercises/practice/grade-school/grade-school-test.el +++ b/exercises/practice/grade-school/grade-school-test.el @@ -6,9 +6,10 @@ (load-file "grade-school.el") -(declare-function roster "grade-school.el" (students)) -(declare-function add "grade-school.el" (students)) -(declare-function grade "grade-school.el" (desired-grade students)) +(declare-function make-school "grade-school.el") +(declare-function roster "grade-school.el" (school)) +(declare-function add "grade-school.el" (school name grade)) +(declare-function grade "grade-school.el" (school grade)) (ert-deftest roster-is-empty-when-no-student-is-added () From c01f798032eb002d5926528be04814bf27badbfe Mon Sep 17 00:00:00 2001 From: fap <459631+fapdash@users.noreply.github.com> Date: Tue, 18 Jun 2024 23:13:55 +0200 Subject: [PATCH 4/4] grade-school: Provide stub for `make-school` function called by test If we provide stubs then the students will reasonably expect us to provide stubs for all the functions expected / called by the test code. --- exercises/practice/grade-school/grade-school.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exercises/practice/grade-school/grade-school.el b/exercises/practice/grade-school/grade-school.el index 702f04cc..9c52d21d 100644 --- a/exercises/practice/grade-school/grade-school.el +++ b/exercises/practice/grade-school/grade-school.el @@ -4,6 +4,8 @@ ;;; Code: +(defun make-school () + (error "Delete this S-Expression and write your own implementation")) (defun roster (school) (error "Delete this S-Expression and write your own implementation"))