Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isogram exercise #366

Merged
merged 2 commits into from
May 5, 2024
Merged

Add isogram exercise #366

merged 2 commits into from
May 5, 2024

Conversation

keiravillekode
Copy link
Contributor

No description provided.

@BNAndras BNAndras added the x:module/practice-exercise Work on Practice Exercises label May 5, 2024
BNAndras
BNAndras requested changes May 5, 2024
View reviewed changes
Copy link
Member

@BNAndras BNAndras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor nitpick for the test suite

exercises/practice/isogram/isogram-test.el
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use (should-not ...) instead of (should (not ...))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@BNAndras BNAndras merged commit 122c82e into exercism:main May 5, 2024
2 checks passed
@BNAndras BNAndras added the x:rep/large Large amount of reputation label May 5, 2024
@keiravillekode keiravillekode deleted the isogram branch May 5, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BNAndras BNAndras BNAndras approved these changes

Assignees
No one assigned
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiravillekode @BNAndras