Add new practice exercise pig-latin
#691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceddlyburge
approved these changes
May 19, 2024
| ( String.fromList first, String.fromList second ) | ||
|
|
||
|
|
||
| takeWhile : (a -> Bool) -> List a -> ( List a, List a ) |
There was a problem hiding this comment.
This is picky, but I would probably rename this function. takeWhile doesn't seem to be what it is doing really. Maybe split or slice or something like that?
There was a problem hiding this comment.
It takes the first part of a list while a condition is true. The only difference with the usual takeWhile is that it returns both parts of the list, and that's clear with the type signature. I think the name makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is coming up in week 20 of 48in24.
Not the most interesting exercise, because it's all about exceptions to a weird rule, but it's not the worst either. I didn't set anything in the
"practices"field because it's clearly all about strings, but we have way too many in that category already.