Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allergies: add missing tests from problem spec #671

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

kahgoh
Copy link
Member

@kahgoh kahgoh commented Mar 21, 2024

While working on the allergies exercise on the Elm track, I noticed there were a number of cases from the problem specification. I used the generate_practice_exercise.sh script to help get the missing tests.

@ceddlyburge
Copy link
Contributor

Hi Kah, thanks for this PR, it looks like you have added a lot of tests, and made things consistent with the other tracks.
Could you take a look at the build errors? I had a very brief look and I think you need to run elm-format.
Cheers, Cedd

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!
Can you also run ./bin/configlet sync --update --tests --exercise allergies to update the tests.toml (it might not even exist yet, I'm not sure)

- Remove unneeded comments
- Remove need to prefix the enumerations
@kahgoh
Copy link
Member Author

kahgoh commented Mar 22, 2024

Cool, thanks! Can you also run ./bin/configlet sync --update --tests --exercise allergies to update the tests.toml (it might not even exist yet, I'm not sure)

Confirming, I've ran this - it didn't produce any diff according to Git. There was already a test.toml that listed all the tests from the problem spec.

@ceddlyburge ceddlyburge merged commit e87636f into exercism:main Mar 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants