-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse-string exercise #642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll leave others a bit of time in case they want to review, but if not I'll merge it next weekend (which I think is a week before it is needed for the 48 in 24 challenge)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, looks good.
Just a note, I'm not a fan of this exercise, since it's too basic (standard lib function). In the Elixir track, we decided not to implement it for the same reason. I don't mind merging too much though, since the 48in24 people will expect it 🤷
exercises/practice/reverse-string/.meta/src/ReverseString.example.elm
Outdated
Show resolved
Hide resolved
I do agree that this is a pointless exercise, and it seems like a strange choice for the 48 in 24. Maybe some languages don't have an equivalent of String.reverse, in which case we could ask students to solve it without using the library function? |
I could add an instructions append to recommend not using the standard library. Strain has similar text in the instructions that we can adapt. I avoided using the built-in reverse to show the exercise is fairly straightforward even without it. |
Adding something to the instructions sounds like a good idea to me. We could even enforce it with the analyzer. Not sure it is worth it though. |
I agree. I'm skeptical that anything to curtail standard library use beyond the append would justify the effort spent. If an append won't suffice, I'm fine not porting the exercise. |
Adding something to the instructions works for me ... |
I don't think this requires adding special instructions, it's not worth it. |
Closes #641