Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse-string exercise #642

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Jan 6, 2024

Closes #641

Copy link
Contributor

@ceddlyburge ceddlyburge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll leave others a bit of time in case they want to review, but if not I'll merge it next weekend (which I think is a week before it is needed for the 48 in 24 challenge)

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good.

Just a note, I'm not a fan of this exercise, since it's too basic (standard lib function). In the Elixir track, we decided not to implement it for the same reason. I don't mind merging too much though, since the 48in24 people will expect it 🤷

@ceddlyburge
Copy link
Contributor

I do agree that this is a pointless exercise, and it seems like a strange choice for the 48 in 24. Maybe some languages don't have an equivalent of String.reverse, in which case we could ask students to solve it without using the library function?

@BNAndras
Copy link
Member Author

BNAndras commented Jan 8, 2024

I could add an instructions append to recommend not using the standard library. Strain has similar text in the instructions that we can adapt. I avoided using the built-in reverse to show the exercise is fairly straightforward even without it.

@ceddlyburge
Copy link
Contributor

Adding something to the instructions sounds like a good idea to me.

We could even enforce it with the analyzer. Not sure it is worth it though.

@BNAndras
Copy link
Member Author

BNAndras commented Jan 8, 2024

I agree. I'm skeptical that anything to curtail standard library use beyond the append would justify the effort spent. If an append won't suffice, I'm fine not porting the exercise.

@ceddlyburge
Copy link
Contributor

Adding something to the instructions works for me ...

@jiegillet
Copy link
Contributor

jiegillet commented Jan 9, 2024

I don't think this requires adding special instructions, it's not worth it. List.reverse is how you'd solve that problem, so be it. Quick and easy exercise.
If you want to implement interesting list-style operations, we have list-ops.

@ceddlyburge ceddlyburge merged commit 5949b5e into exercism:main Jan 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port reverse-string?
3 participants