Add grains exercise #246
Merged
Add grains exercise #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom
approved these changes
Jan 3, 2024
ladokp
reviewed
Jan 3, 2024
| @@ -0,0 +1,6 @@ | |||
| class Grains | |||
| @square: (number) -> | |||
There was a problem hiding this comment.
Why are this "@" signs in front of the methods? To pass the tests I had to remove them in my solution.
There was a problem hiding this comment.
It looks like the tests are not synchronized with this change.
There was a problem hiding this comment.
Could you elaborate on the tests not being synchronized? configlet isn't seeing any missing.
./bin/configlet sync --tests -e grains
Updating cached 'problem-specifications' data...
Checking exercises...
The `grains` exercise has up-to-date tests!
There was a problem hiding this comment.
Why are this "@" signs in front of the methods?
That signifies they are class methods so Grains.square() and new Grains.square() both work. I'll investigate further, but the example passed the CI.
There was a problem hiding this comment.
I opened up #249 so we can iterate there.
BNAndras
added
x:module/practice-exercise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #236