Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable runner #81

Merged
merged 2 commits into from
Mar 6, 2024
Merged

enable runner #81

merged 2 commits into from
Mar 6, 2024

Conversation

lucaferranti
Copy link
Member

Closes: #38

@lucaferranti
Copy link
Member Author

mmm if I start mess-up one-line PRs, maybe I should call it a day for now 😴

@ErikSchierboom
Copy link
Member

@lucaferranti You'll need to add a test_runner.average_run_time field that estimates the amount of time the test runner takes (as an integer representing seconds). See https://exercism.org/docs/building/tracks/config-json#h-metadata
Judging by the speed running the tests of the test runner locally, it should probably be set to about 10 or so.

FYI I've opened a PR that we need to merge to allow deploying the test runner to production: exercism/terraform#109

@lucaferranti
Copy link
Member Author

cool, I've set the average time. Just double-checking this is indeed average time, not maximum time threshold to timeout? Anyway, once the test-runner is deployed, I can test on the website an exercise wiht a lot of tests and see if it causes problems

@ErikSchierboom
Copy link
Member

It is indeed average run time (it's just there for the progress bar than is shown when submitting)

@lucaferranti
Copy link
Member Author

@ErikSchierboom fixed the missing field. Let me know if anything else is missing

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaferranti lucaferranti merged commit 6d220d6 into main Mar 6, 2024
2 checks passed
@lucaferranti lucaferranti deleted the lf-runner branch March 6, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tooling
2 participants