Address maintainer feedback #99
Conversation
| @@ -20,8 +20,7 @@ | |||
| }, | |||
| "files": { | |||
| "solution": [ | |||
| "src/lib.cairo", | |||
| "Scarb.toml" | |||
There was a problem hiding this comment.
@ErikSchierboom should removing Scarb.toml from this array also remove it from the online editor?
Removed it from all the other config.json files.
http://forum.exercism.org/t/need-maintainers-to-test-the-new-cairo-track/12154/10
There was a problem hiding this comment.
@misicnenad Yes, it will remove it from the online editor. What I would suggest you do is to not remove it, but instead put it in the invalidator key. This will ensure that if the Scarb.toml file changes, students will be prompted to update the exercise. An invalidator files are not shown in the online editor. See https://exercism.org/docs/building/tracks/practice-exercises#h-file-meta-config-json
There was a problem hiding this comment.
Done 160a33a
Let me know if this is the change you expected to see, and I'll merge this
http://forum.exercism.org/t/need-maintainers-to-test-the-new-cairo-track/12154/6