Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn lucians-luscious-lasagna into a Concept Exercise + fix low-power-embedded-game #156

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Sep 4, 2024

Closes #148

Also implemented AbsImpl to allow students to focus solely on tuples

@0xNeshi 0xNeshi self-assigned this Sep 4, 2024
@0xNeshi 0xNeshi mentioned this pull request Sep 4, 2024
@0xNeshi
Copy link
Contributor Author

0xNeshi commented Sep 4, 2024

@ErikSchierboom I am no longer able to merge my own nor other contributors' PRs, do you know what's going on?

@0xNeshi 0xNeshi merged commit ff2ecf9 into main Sep 4, 2024
5 checks passed
@0xNeshi 0xNeshi deleted the concept-exercises branch September 4, 2024 15:59
@BNAndras
Copy link
Member

BNAndras commented Sep 4, 2024

My understanding is that while a track isn't launched, no reviews are needed before merging. On a live track, PRs should be reviewed by someone with write access besides the submitter before merging. So if Erik changed the merge settings, that'd make sense as to why you can't merge your own. That's pretty odd that you can't merge other PRs. If that just started occurring, it might be related to the work staff did in the last day to give @exercism/cross-track-maintainers write access to most of the track repos.

I'm a member of that team so I can wave your PRs through as needed.

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Sep 4, 2024

@BNAndras

On a live track, PRs should be reviewed by someone with write access besides the submitter before merging.

Ok, makes sense. But just 2 days ago I was able to merge my own PRs, see #139 and #144 🤔 Maybe there were recent changes to the merge settings.

That's pretty odd that you can't merge other PRs.

Just tried it with #49 and was able to merge it only if I previously explicitly approved it. It might be faulty memory of mine, but I feel like I was able to merge other people's PRs without explicit approval.

@BNAndras
Copy link
Member

BNAndras commented Sep 4, 2024

Sounds about right if the staff weren't able to change those track settings before launch. So the issue at hand is that PR reviews are now required before merging, not that you can't merge a PR after a review was done, right? The former is expected behavior, but the latter might be indicative of a bug.

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Sep 4, 2024

Exactly. I've been in contact with Exercism support, and they explained they'd like all PRs to be reviewed by someone, even PRs from maintainers. The fact I was ever able to merge my own PRs on a live track was actually the problem 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn lucians-luscious-lasagna into a Concept Exercise
2 participants