Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testfix #197

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Testfix #197

merged 3 commits into from
Jun 15, 2024

Conversation

axtens
Copy link
Member

@axtens axtens commented Jun 15, 2024

PR'ed not from fork.

@axtens axtens requested review from glennj and ErikSchierboom June 15, 2024 14:40
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@axtens
Copy link
Member Author

axtens commented Jun 15, 2024

Woo hoo! All checks passed!!

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@glennj
Copy link
Contributor

glennj commented Jun 15, 2024

@ErikSchierboom this PR will re-test everything in the track. Is this a case for [no important files changed] even though important files are changed?

@ErikSchierboom
Copy link
Member

I think so, as it shouldn't really influence the test results, right?

@glennj glennj merged commit 8f29446 into main Jun 15, 2024
4 checks passed
@glennj glennj deleted the testfix branch June 15, 2024 19:09
@glennj
Copy link
Contributor

glennj commented Jun 15, 2024

@axtens Thanks for following up with this.

@axtens
Copy link
Member Author

axtens commented Jun 16, 2024

It had to be done. It was a "call of duty" thing. It wasn't unpleasant, just fiddly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants