Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no more array insensitive dots as recent 8th update corrects array to… #194

Closed
wants to merge 1 commit into from

Conversation

axtens
Copy link
Member

@axtens axtens commented Jun 2, 2024

… string conversion issue

So I thought this had been dealt with. But I was just trying to update my repo to the upstream and go sync error

@axtens axtens requested a review from glennj June 2, 2024 08:21
Comment on lines -22 to -28

: test-passed \ s x x -- \\ test name, expected value, actual value
2drop
1 tests-passed n:+!
con:green con:onBlack . space " ... OK" . con:white con:onBlack cr
;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much deleted for grains.

Comment on lines -22 to -28

: test-passed \ s x x -- \\ test name, expected value, actual value
2drop
1 tests-passed n:+!
con:green con:onBlack . space " ... OK" . con:white con:onBlack cr
;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much deleted for pythagorean-triplet

Comment on lines -22 to -28

: test-passed \ s x x -- \\ test name, expected value, actual value
2drop
1 tests-passed n:+!
con:green con:onBlack . space " ... OK" . con:white con:onBlack cr
;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much deleted for series

Comment on lines -23 to -28
: test-passed \ s x x -- \\ test name, expected value, actual value
2drop
1 tests-passed n:+!
con:green con:onBlack . space " ... OK" . con:white con:onBlack cr
;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieve too

@axtens
Copy link
Member Author

axtens commented Jun 2, 2024

Okay, so what's the best way of handling this?

@glennj
Copy link
Contributor

glennj commented Jun 2, 2024

@axtens
Copy link
Member Author

axtens commented Jun 3, 2024

Not quite what I meant. I'll have another look tonight (Currently 14:19 UTC+8)

@glennj
Copy link
Contributor

glennj commented Jun 3, 2024

Did I misunderstand "what's the best way of handling this"? Make the change in libs/exercism/test and copy it to the exercises. That way, you minimize editing errors.

@axtens
Copy link
Member Author

axtens commented Jun 3, 2024

I'm not disputing your advice. It's correct. The difficulty is with my understand of the situation. I have a test library in 8th/libs/exercism/test that has, on line 67-68

   \ otherwise fall back to 'lazy evaluation'
   l: =

and it is this line that the other exercises are bombing on. So will copying this file to those exercises fix the problem?

@axtens
Copy link
Member Author

axtens commented Jun 3, 2024

I didn't write the test library.

@glennj
Copy link
Contributor

glennj commented Jun 3, 2024

That came from Ron:
https://8th-dev.com/forum/index.php?topic=2745.msg15984#msg15984

I see in the words list:

l: --
  IMMEDIATE needs utils/latebind Makes the next word "delayed lookup". Compiles the string  into the word currently being compiled. At runtime, every time the code is invoked, it looks up the word with that name. So l: + will add two numbers, or concatenate two strings, using the same code.

Try adding needs utils/latebind to the test file

@axtens axtens closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants