Added sleep in dataframe_memory_leak test after gc collection #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Jan 31, 2025
| @@ -111,6 +112,7 @@ def run(ctx): | |||
| assert memory_check_executed == False #Sanity check for row number | |||
| print("Checking memory usage", flush=True) | |||
| gc.collect() | |||
| time.sleep(1) | |||
There was a problem hiding this comment.
In case it works we should a comment to the sleeps
There was a problem hiding this comment.
Done.
The CI Build failed because of Docker.
tkilias
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#1060
We suspect that GC is not finished when the test reads the memory snapshot => Sleep 1s after triggerer GC might fix this problem.
I ran the AWS Build with exasol/script-languages-release#1061 3x and it worked. So the workaround looks promising.