Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for .coop #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mxroo
Copy link

@mxroo mxroo commented Apr 2, 2020

We use this plugin, and want to check our own url, added code to support that, copied from the .org code.

@ewypych
Copy link
Owner

ewypych commented May 20, 2020

Hi @mxroo - sorry for such a late answer. :( Could you please also add .us domain to README file? Thanks! Then I will merge your changes and make a new release. :)

elif [ "$DTYPE" == "coop" ]
then
EXDATE_TMP=$(${WHOIS} -h whois.nic.coop "${1}" | ${AWK} '/Expiry Date:/ { print $4 }' | cut -c 1-16)
EXDATE=`date -d"$EXDATE_TMP" +%Y-%m-%d`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be done in accordance with #15 – it fixed the problem with no expiration date in the WHOIS response. Could you please update the code to meet these requirements? As an example, you can use .moscow domain. I mean additional conditional that checks if EXDATE is empty:

EXDATE_TMP=$(${WHOIS} "${1}" | ${AWK} '/Registry Expiry Date:/ { print $4 }' | cut -c 1-16)
if [ -z "$EXDATE_TMP" ]
then
    EXP_DAYS=NULL

elif [ "$DTYPE" == "us" ]
then
EXDATE_TMP=$(${WHOIS} -h whois.nic.us "${1}" | ${AWK} '/Expiry Date:/ { print $4 }' | cut -c 1-16)
EXDATE=`date -d"$EXDATE_TMP" +%Y-%m-%d`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be done in accordance with #15 – it fixed the problem with no expiration date in the WHOIS response. Could you please update the code to meet these requirements? As an example, you can use .moscow domain. I mean additional conditional that checks if EXDATE is empty:

EXDATE_TMP=$(${WHOIS} "${1}" | ${AWK} '/Registry Expiry Date:/ { print $4 }' | cut -c 1-16)
if [ -z "$EXDATE_TMP" ]
then
    EXP_DAYS=NULL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants