From 7c8c44fc185f9501c5ec66714f60180e0570b1a2 Mon Sep 17 00:00:00 2001 From: Ewan Miller Date: Wed, 25 Sep 2024 23:06:31 +0100 Subject: [PATCH 1/6] Add threshold in benchmarking.yaml --- .github/workflows/benchmarking.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarking.yaml b/.github/workflows/benchmarking.yaml index 79d6795..e048cf5 100644 --- a/.github/workflows/benchmarking.yaml +++ b/.github/workflows/benchmarking.yaml @@ -60,7 +60,16 @@ jobs: working-directory: ${{github.workspace}}/build # Build your program with the given configuration run: make --trace #cmake --build ${{github.workspace}}/build - + + - name: Set Up Threshold + run: bencher threshold create \ + --branch '${{ github.head_ref }}' \ + --testbed ubuntu-latest \ + --measure Latency \ + --test percentage \ + --upper-boundary 0.0 \ + nuTens + - name: Track PR Benchmarks with Bencher working-directory: ${{github.workspace}}/build run: | From 8f074e553149832623328ef1db77d9f57c31c0cd Mon Sep 17 00:00:00 2001 From: Ewan Miller Date: Wed, 25 Sep 2024 23:18:38 +0100 Subject: [PATCH 2/6] Fix syntax --- .github/workflows/benchmarking.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarking.yaml b/.github/workflows/benchmarking.yaml index e048cf5..3983341 100644 --- a/.github/workflows/benchmarking.yaml +++ b/.github/workflows/benchmarking.yaml @@ -62,7 +62,8 @@ jobs: run: make --trace #cmake --build ${{github.workspace}}/build - name: Set Up Threshold - run: bencher threshold create \ + run: | + bencher threshold create \ --branch '${{ github.head_ref }}' \ --testbed ubuntu-latest \ --measure Latency \ From 78ea2641297ec35496c8d6f1c7da8515231a7683 Mon Sep 17 00:00:00 2001 From: Ewan Miller Date: Wed, 25 Sep 2024 23:23:53 +0100 Subject: [PATCH 3/6] Fix project name --- .github/workflows/benchmarking.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarking.yaml b/.github/workflows/benchmarking.yaml index 3983341..41f601d 100644 --- a/.github/workflows/benchmarking.yaml +++ b/.github/workflows/benchmarking.yaml @@ -69,7 +69,7 @@ jobs: --measure Latency \ --test percentage \ --upper-boundary 0.0 \ - nuTens + nutens - name: Track PR Benchmarks with Bencher working-directory: ${{github.workspace}}/build From a701b3abe1e02290aef79bd3ee0fc08da6a3fa06 Mon Sep 17 00:00:00 2001 From: Ewan Miller Date: Wed, 25 Sep 2024 23:28:21 +0100 Subject: [PATCH 4/6] Forgot to set the token. Oops --- .github/workflows/benchmarking.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/benchmarking.yaml b/.github/workflows/benchmarking.yaml index 41f601d..07f0ebc 100644 --- a/.github/workflows/benchmarking.yaml +++ b/.github/workflows/benchmarking.yaml @@ -64,6 +64,7 @@ jobs: - name: Set Up Threshold run: | bencher threshold create \ + --token '${{ secrets.BENCHER_API_TOKEN }}' \ --branch '${{ github.head_ref }}' \ --testbed ubuntu-latest \ --measure Latency \ From d3d8ea156d6ec088321168decf1a85e5d94b3b1b Mon Sep 17 00:00:00 2001 From: Ewan Miller Date: Wed, 25 Sep 2024 23:37:02 +0100 Subject: [PATCH 5/6] Try again with branch-reset option --- .github/workflows/benchmarking.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/benchmarking.yaml b/.github/workflows/benchmarking.yaml index 07f0ebc..5f5a895 100644 --- a/.github/workflows/benchmarking.yaml +++ b/.github/workflows/benchmarking.yaml @@ -68,6 +68,7 @@ jobs: --branch '${{ github.head_ref }}' \ --testbed ubuntu-latest \ --measure Latency \ + --branch-reset\ --test percentage \ --upper-boundary 0.0 \ nutens From 878f742120b2283f9245a79337bb9836a14e89ca Mon Sep 17 00:00:00 2001 From: Ewan Miller Date: Wed, 25 Sep 2024 23:41:45 +0100 Subject: [PATCH 6/6] Hmmm --- .github/workflows/benchmarking.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarking.yaml b/.github/workflows/benchmarking.yaml index 5f5a895..9c5a82f 100644 --- a/.github/workflows/benchmarking.yaml +++ b/.github/workflows/benchmarking.yaml @@ -68,7 +68,7 @@ jobs: --branch '${{ github.head_ref }}' \ --testbed ubuntu-latest \ --measure Latency \ - --branch-reset\ + --branch-reset \ --test percentage \ --upper-boundary 0.0 \ nutens