Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/text annotator menu #139

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Feature/text annotator menu #139

wants to merge 14 commits into from

Conversation

giacomocerre
Copy link
Collaborator

No description provided.

@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch from 664d1cd to 8ef6bad Compare April 24, 2021 15:52
szenzaro
szenzaro requested changes May 3, 2021
View reviewed changes
src/app/app.module.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.html Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/app.component.html Show resolved Hide resolved
giuliac89
giuliac89 requested changes May 3, 2021
View reviewed changes
Copy link
Member

@giuliac89 giuliac89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improves the layout. Maybe I would remove the labels and leave only the icons (changing the annotation icon in to a more explanatory one). Do you have a layout in mind?

src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch 2 times, most recently from 3a77f4a to 392a112 Compare May 8, 2021 09:24
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch 2 times, most recently from 2cc48ae to 1bc4dad Compare June 5, 2021 17:35
szenzaro
szenzaro requested changes Jun 10, 2021
View reviewed changes
src/app/app.module.ts Outdated Show resolved Hide resolved
src/app/app.config.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated

openCreation(choice){
this.annoType = choice;
this.showAdder = choice !== 'annotate' ? true : false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need of ternary operator: choice !== 'annotate' is enough

src/app/components/annotator/text-annotator/text-annotator.component.ts Outdated Show resolved Hide resolved
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch 3 times, most recently from cb422f9 to b56752d Compare June 11, 2021 11:10
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch 3 times, most recently from b59469c to 52a3f21 Compare July 8, 2021 08:24
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch 2 times, most recently from 43239e8 to 6d61dd1 Compare May 30, 2022 16:30
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch 2 times, most recently from 05d0fae to ddd7149 Compare February 25, 2023 16:42
@giacomocerre giacomocerre force-pushed the feature/text-annotator-menu branch from ddd7149 to 92ff3cb Compare February 25, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szenzaro szenzaro szenzaro requested changes

@giuliac89 giuliac89 giuliac89 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giacomocerre @szenzaro @giuliac89 @davivcu