Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbo reference attributes: SEO対策として検索に利用されそうなワードを追加 #116

Conversation

otegami
Copy link
Collaborator

@otegami otegami commented Dec 6, 2024

ref GH-103

@@ -1,7 +1,10 @@
---
order: 5
title: "属性とメタタグ"
description: "属性とメタタグのリファレンス"
description: |
Hotwire ドキュメント(有志翻訳版)です。
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotwire Turbo ハンドブック(翻訳版)に合わせたほうが良さそう!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#115 (comment) の結論をもとに更新する。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: 8544b5c

「Hotwire ドキュメント(有志翻訳版): Turbo ハンドブック」の部分は他の部分とドキュメンの description でも共通して利用することになると思うので、もう少しこなれた表現があったらサジェストいただきたいです 🙏🏾

@otegami otegami force-pushed the turbo-reference-make-description-better-for-seo branch from 06833b2 to 8544b5c Compare December 14, 2024 00:46
@@ -1,7 +1,9 @@
---
order: 5
title: "属性とメタタグ"
description: "属性とメタタグのリファレンス"
description: |
「Hotwire ドキュメント(有志翻訳版): Turbo ハンドブック」における属性とメタタグに関するリファレンスページです。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リファレンスの下は #122 の表現に揃えると良さそうです

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すっかり遅くなってしまい申し訳ないです。
fix: fb19303 にて対応を行いました。合わせて rebase もしました 🙏

@otegami otegami force-pushed the turbo-reference-make-description-better-for-seo branch from 8544b5c to fb19303 Compare January 25, 2025 03:01
Copy link
Contributor

@akira888 akira888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yakitorii yakitorii merged commit 94db1ee into everyleaf:main Jan 31, 2025
1 check passed
@otegami otegami deleted the turbo-reference-make-description-better-for-seo branch January 31, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants