[Fix]: Update Select Components in manual time modal #3609
Conversation
- Replace SelectItems with CustomSelect component - Standardize select styling across teams, tasks and reasons - Fix value handling for team and task selection - Remove unused SelectItems import
WalkthroughThis pull request introduces several styling updates across three components. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
apps/web/lib/features/manual-time/add-manual-time-modal.tsxOops! Something went wrong! :( ESLint: 8.46.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (1)
192-198:⚠️ Potential issueRemove debug console.log statements.
Debug logging statements should be removed before merging to production.
const handleSelectedValuesChange = (values: { [key: string]: Item | null }) => { - console.log(values); }; const handleChange = (field: string, selectedItem: Item | null) => { - console.log(`Field: ${field}, Selected Item:`, selectedItem); };
🧹 Nitpick comments (1)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (1)
330-340: Add error handling for CustomSelect components.While the CustomSelect implementations are consistent, they lack error handling for failed selections. Consider adding error states and user feedback.
<CustomSelect valueKey="id" defaultValue={activeTeam?.id ?? ''} classNameGroup="max-h-[40vh] dark:!text-white " ariaLabel="teams" className="w-full border-gray-300 dark:border-slate-600 dark:text-white" options={teams || []} onChange={(value) => { + try { setTeam(value.id); + } catch (error) { + setErrorMsg('Failed to select team. Please try again.'); + } }} + onError={(error) => setErrorMsg('Failed to load teams. Please try again.')} />Also applies to: 348-358, 377-385
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/app/[locale]/dashboard/app-url/components/ProductivityTable.tsx(1 hunks)apps/web/app/[locale]/timesheet/[memberId]/components/CompactTimesheetComponent.tsx(2 hunks)apps/web/lib/features/manual-time/add-manual-time-modal.tsx(11 hunks)
✅ Files skipped from review due to trivial changes (1)
- apps/web/app/[locale]/dashboard/app-url/components/ProductivityTable.tsx
🧰 Additional context used
🧠 Learnings (1)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (1)
Learnt from: Innocent-Akim
PR: ever-co/ever-teams#3208
File: apps/web/app/[locale]/timesheet/components/TimesheetFilter.tsx:30-35
Timestamp: 2024-11-12T14:06:02.202Z
Learning: In the `TimesheetFilter` component, the `Add Time` button does not need to use the `AddManualTimeModal` component, as per the user's decision.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: deploy
🔇 Additional comments (3)
apps/web/app/[locale]/timesheet/[memberId]/components/CompactTimesheetComponent.tsx (1)
5-5: LGTM! Class name reordering maintains functionality.The reordering of class names in both the LoadingSpinner and ImageWithLoader components is a clean-up change that doesn't affect the component's behavior.
Also applies to: 32-32
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (2)
5-5: LGTM! Import changes align with component updates.The import changes correctly support the replacement of SelectItems with CustomSelect.
Also applies to: 21-21
172-180: LGTM! Employee selection is properly configured.The employee selection field is correctly implemented with:
- Proper conditional rendering
- Translation support
- Required field validation
- Remove unnecessary || [] conditions from CustomSelect options - Clean up options handling for teams, tasks, and reasons selects - Improve code clarity by removing redundant array conversions
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (4)
172-179: Consider adding type safety to field configurations.While the employee field configuration is well-structured, consider creating a type for the field configuration to ensure type safety and maintainability.
type FieldConfig = { label: string; placeholder: string; isRequired: boolean; valueKey: string; displayKey: string; element: 'Project' | 'Employee' | 'Task'; };
192-198: Remove console.log statements before deployment.Development logs should be removed from production code.
const handleSelectedValuesChange = (values: { [key: string]: Item | null }) => { - console.log(values); }; const handleChange = (field: string, selectedItem: Item | null) => { - console.log(`Field: ${field}, Selected Item:`, selectedItem); };
330-340: Consider extracting common CustomSelect configuration.The CustomSelect components share similar configurations. Consider extracting the common configuration to reduce duplication and improve maintainability.
const commonSelectConfig = { classNameGroup: "max-h-[40vh] dark:!text-white", className: "w-full border-gray-300 dark:border-slate-600 dark:text-white" }; // Usage <CustomSelect {...commonSelectConfig} valueKey="id" defaultValue={activeTeam?.id ?? ''} ariaLabel="teams" options={teams} onChange={(value) => setTeam(value.id)} />Also applies to: 348-358, 377-385
93-101: Enhance error handling for form submission.The current error handling is basic. Consider implementing more specific error messages and handling edge cases.
if (!date) { setErrorMsg(t('errors.DATE_REQUIRED')); return; } if (!startTime) { setErrorMsg(t('errors.START_TIME_REQUIRED')); return; } if (!endTime) { setErrorMsg(t('errors.END_TIME_REQUIRED')); return; } if (!team) { setErrorMsg(t('errors.TEAM_REQUIRED')); return; } if (!taskId) { setErrorMsg(t('errors.TASK_REQUIRED')); return; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx(11 hunks)
🧰 Additional context used
🧠 Learnings (1)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (1)
Learnt from: Innocent-Akim
PR: ever-co/ever-teams#3208
File: apps/web/app/[locale]/timesheet/components/TimesheetFilter.tsx:30-35
Timestamp: 2024-11-12T14:06:02.202Z
Learning: In the `TimesheetFilter` component, the `Add Time` button does not need to use the `AddManualTimeModal` component, as per the user's decision.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: deploy
🔇 Additional comments (2)
apps/web/lib/features/manual-time/add-manual-time-modal.tsx (2)
5-5: LGTM! Import changes align with component updates.The removal of SelectItems and addition of CustomSelect imports align with the PR objectives.
Also applies to: 21-21
41-161: LGTM! State management is well-structured.The component maintains clean state management with proper separation of concerns.
Description
Please include a summary of the changes and the related issues.
Type of Change
Checklist
Previous screenshots
Screen.Recording.2025-02-12.at.1.24.10.PM.mov
Please add here videos or images of the previous status
Current screenshots
Summary by CodeRabbit