-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In memory inline projections - Add inMemoryDatabase #186
Merged
oskardudycz
merged 2 commits into
event-driven-io:main
from
stepaniukm:in-memory-inline-projections
Feb 11, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import { JSONParser } from '../serialization'; | ||
|
||
export interface DocumentsCollection<T> { | ||
store: (id: string, obj: T) => void; | ||
delete: (id: string) => void; | ||
get: (id: string) => T | null; | ||
} | ||
|
||
export type DocumentHandler<T> = | ||
| ((document: T | null) => T | null) | ||
| ((document: T | null) => Promise<T | null>); | ||
|
||
export interface Database { | ||
collection: <T>(name: string) => DocumentsCollection<T>; | ||
} | ||
|
||
export const getInMemoryDatabase = (): Database => { | ||
const storage = new Map<string, unknown>(); | ||
|
||
return { | ||
collection: <T>( | ||
collectionName: string, | ||
_collectionOptions: { | ||
errors?: { throwOnOperationFailures?: boolean } | undefined; | ||
} = {}, | ||
): DocumentsCollection<T> => { | ||
const toFullId = (id: string) => `${collectionName}-${id}`; | ||
|
||
const collection = { | ||
store: (id: string, obj: T): void => { | ||
storage.set(toFullId(id), obj); | ||
}, | ||
delete: (id: string): void => { | ||
storage.delete(toFullId(id)); | ||
}, | ||
get: (id: string): T | null => { | ||
const result = storage.get(toFullId(id)); | ||
|
||
return result | ||
? // Clone to simulate getting new instance on loading | ||
(JSONParser.parse(JSONParser.stringify(result)) as T) | ||
: null; | ||
}, | ||
}; | ||
|
||
return collection; | ||
}, | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QUESTION: @stepaniukm, is it intentional that members in this file are not exposed in the main index file? I'm fine with not exposing them yet until it's ready; I'm just double-checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that is intentional, first I want to complete migration to something actually usable, tested and more stable, before exposing it publicly. One little thing I removed type
DocumentHandler
that will be a part of future effort.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stepaniukm, I'll pull in your changes and add the export. I think that it could be useful for folks to have even such in-memory db 👌