Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In memory inline projections - Add inMemoryDatabase #186

Merged

Conversation

stepaniukm
Copy link
Contributor

This PR covers the first two steps of this issue: #179

@@ -0,0 +1,49 @@
import { JSONParser } from '../serialization';

export interface DocumentsCollection<T> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QUESTION: @stepaniukm, is it intentional that members in this file are not exposed in the main index file? I'm fine with not exposing them yet until it's ready; I'm just double-checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that is intentional, first I want to complete migration to something actually usable, tested and more stable, before exposing it publicly. One little thing I removed type DocumentHandler that will be a part of future effort.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stepaniukm, I'll pull in your changes and add the export. I think that it could be useful for folks to have even such in-memory db 👌

Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @stepaniukm, after getting an answer to the question, I'm happy to merge it!

@oskardudycz oskardudycz added this to the 0.27.0 milestone Feb 11, 2025
@oskardudycz oskardudycz merged commit 7bf96d4 into event-driven-io:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants