Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates-translations-fr #18799

Closed
wants to merge 4 commits into from

Conversation

FraBoCH
Copy link
Contributor

@FraBoCH FraBoCH commented Feb 14, 2025

With the new configuration UI, most device configuration forms are displaying content coming from templates and not the i18n resources managed in Weblate. As an important contributor to evcc French translation, I’m going further and added in this PR French translations to field descriptions and help texts used in most templates.

@naltatis
Copy link
Member

Hi @FraBoCH, right now we don't plan to support device specific documentation beside English and German.

I see your point and I agree, that it would be helpful to also have more translation for the devices. But before we can address this we have to complete two important things:

  • having config ui 100% complete
  • found a model to enable weblate-style community translations for devices

The last one is the most critical since we can't deal with individual translation requests for all devices. Otherwise we would have to process ten's of lang-specific followup PRs for each new device we add to the codebase.

Thank your for the work you've already put into this PR and sorry, that we can't simply merge this. But I hope you understand my thoughts on this.

@naltatis naltatis closed this Feb 14, 2025
@andig
Copy link
Member

andig commented Feb 14, 2025

It's really unfortunate but I agree that in it's current form it would do more are than help. Really sorry here!

Copy link
Contributor Author

@FraBoCH FraBoCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand. I also think a proper i18n mechanism should be put in place for templates. I’ll be happy to help for French.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants