Temperature sensor of AC Thor / AC Thor 9s can be choosen as source for Soc #18431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he temperature source to be used as Soc. Possible values are 1001, 1030 and 1031
andig
reviewed
Jan 26, 2025
| @@ -9,6 +9,14 @@ requirements: | |||
| params: | |||
| - name: modbus | |||
| choice: ["tcpip"] | |||
| - name: tempsource | |||
| choice: ["1001", "1030", "1031"] | |||
There was a problem hiding this comment.
Please use sensor name 1/2/3. Users won't know know the modbus register.
andig
reviewed
Jan 26, 2025
|
Looks good, thank you! Last wish: please hand sensor index to the go code and have the actual registers in go. That's what we do with other modules, too to keep the go part reusable. |
you mean: handover the 1,2,3 to the go code an assign the modbus registers there? |
…he index in ac-elwa-2.yaml and ac-thor.yaml
merge latest changes into walburgf/evcc
|
wie wird denn die Doku geändert, damit man auch weiss, dass es einen zusätzlichen Parameter gibt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in evcc.yaml, the temperature sensor of the AC Thor (9s) can be choosen by entering tempsource: "value".
"value" is the modbus register of the respective temperature sensor (1001, 1030 or 1031). Default is 1001