Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMA eCharger #18158

Merged
merged 11 commits into from
Feb 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions charger/smaevcharger.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,22 +236,32 @@ var _ api.MeterEnergy = (*Smaevcharger)(nil)

// TotalEnergy implements the api.MeterEnergy interface
func (wb *Smaevcharger) TotalEnergy() (float64, error) {
val, err := wb.getMeasurement("Measurement.Metering.GridMs.TotWhIn")
return val / 1e3, err
res, err := wb.getMeasurement("Measurement.Metering.GridMs.TotWhIn")
if se := new(smaevcharger.ErrUnknownMeasurement); errors.As(err, &se) {
res, err = wb.getMeasurement("Measurement.Metering.GridMs.TotWhIn.ChaSta")
}
return res / 1e3, err
}

var _ api.Meter = (*Smaevcharger)(nil)

// CurrentPower implements the api.Meter interface
func (wb *Smaevcharger) CurrentPower() (float64, error) {
return wb.getMeasurement("Measurement.Metering.GridMs.TotWIn")
res, err := wb.getMeasurement("Measurement.Metering.GridMs.TotWIn")
if se := new(smaevcharger.ErrUnknownMeasurement); errors.As(err, &se) {
res, err = wb.getMeasurement("Measurement.Metering.GridMs.TotWIn.ChaSta")
}
return res, err
}

var _ api.ChargeRater = (*Smaevcharger)(nil)

// ChargedEnergy implements the api.ChargeRater interface
func (wb *Smaevcharger) ChargedEnergy() (float64, error) {
res, err := wb.getMeasurement("Measurement.ChaSess.WhIn")
if se := new(smaevcharger.ErrUnknownMeasurement); errors.As(err, &se) {
res, err = wb.getMeasurement("Measurement.Metering.GridMs.TotWhIn.ChaSta")
}
return res / 1e3, err
}

Expand Down Expand Up @@ -317,7 +327,7 @@ func (wb *Smaevcharger) getMeasurement(id string) (float64, error) {
}
}

return 0, fmt.Errorf("unknown measurement: %s", id)
return 0, &smaevcharger.ErrUnknownMeasurement{Measurement: id}
}

func (wb *Smaevcharger) getParameter(id string) (string, error) {
Expand Down
8 changes: 8 additions & 0 deletions charger/smaevcharger/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ const (
ChargerManualLockDisabled = "5172"
)

type ErrUnknownMeasurement struct {
Measurement string
}

func (e *ErrUnknownMeasurement) Error() string {
return "unknown measurement: " + e.Measurement
}

// Measurements Data json Response structure
type Measurements struct {
ChannelId string `json:"channelId"`
Expand Down
2 changes: 1 addition & 1 deletion templates/definition/charger/smaevcharger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ template: smaevcharger
products:
- brand: SMA
description:
generic: EV Charger
generic: EV Charger, eCharger
capabilities: ["mA"]
requirements:
evcc: ["sponsorship"]
Expand Down
4 changes: 2 additions & 2 deletions util/decoder.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ func NewConfigError(err error) error {
return &ConfigError{err}
}

func (e *ConfigError) Error() string {
func (e ConfigError) Error() string {
return e.err.Error()
}

func (e *ConfigError) Unwrap() error {
func (e ConfigError) Unwrap() error {
return e.err
}
Loading