Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadpoint: use measured power for calculation if available #13427

Closed
wants to merge 1 commit into from
Closed

Loadpoint: use measured power for calculation if available #13427

wants to merge 1 commit into from

Conversation

Henrik0x7F
Copy link

Instead of assuming the loadpoint is charging with lp.effectiveCurrent use lp.chargeMeter.CurrentPower() to calculate the actual charging current. If no power measurement is available, fall back to the old method.

This fixes #13322 where loads with long reaction times cause evcc to allow more current than available which results in oscillation.

Tested it on my installation without problems but may need some testing in other configurations.

@premultiply premultiply requested a review from andig April 14, 2024 12:28
@andig
Copy link
Member

andig commented Apr 14, 2024

This fixes #13322 where loads with long reaction times cause evcc to allow more current than available which results in oscillation.

It seems that root cause for you is that your charger does not provide current measurement? Otherwise lp.effectiveCurrent should already return the expected value.

Ich denke wenn gehört das in lp.effectiveCurrent denn dort wird der Strom ermittelt. Der sollte nicht hinterher willenlos durch eine Leistungsumrechnung ersetzt werden. Was mich in lp.effectiveCurrent stört ist, dass wir dort noch 2A aufschlagen. Ich kann nicht mehr so richtig nachvollziehen, was genau die Mechanik dahinter ist?

@Henrik0x7F der aktuelle Leistungsmesswert liegt bereits in lp.chargePower, muss also auch nicht nochmal abgerufen werden.

@andig andig marked this pull request as draft April 14, 2024 13:17
@Henrik0x7F
Copy link
Author

It seems that root cause for you is that your charger does not provide current measurement? Otherwise lp.effectiveCurrent should already return the expected value.

Geht das mit einem Custom Charger? Bin dem Modbus Gesamtbeispiel hier gefolgt, da wurde nicht gezeigt, dass das geht.

Wenn lp.effectiveCurrent über Modbus eingelesen werden kann, dann ist das PR natürlich überflüssig. Habe ich in der Doku leider nicht gefunden

@andig
Copy link
Member

andig commented Apr 14, 2024

Das sollte gehen wenn du einen zusätzlichen Zähler am Loadpoint konfigurierst der das kann. Scheint damit hätte sich dieser Request erledigt :)

@andig andig closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants