Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
andig authored Apr 21, 2024
1 parent a73d761 commit 605b3b6
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions charger/em2go-home.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,19 +198,16 @@ var _ api.PhaseCurrents = (*Em2GoHome)(nil)
// Currents implements the api.PhaseCurrents interface
func (wb *Em2GoHome) Currents() (float64, float64, float64, error) {
b, err := wb.conn.ReadHoldingRegisters(em2GoHomeRegCurrent1, 1)

if err != nil {
return 0, 0, 0, err
}

c, err := wb.conn.ReadHoldingRegisters(em2GoHomeRegCurrent2, 1)

if err != nil {
return 0, 0, 0, err
}

d, err := wb.conn.ReadHoldingRegisters(em2GoHomeRegCurrent3, 1)

if err != nil {
return 0, 0, 0, err
}
Expand All @@ -225,19 +222,16 @@ var _ api.PhaseVoltages = (*Em2GoHome)(nil)
// Currents implements the api.PhaseVoltages interface
func (wb *Em2GoHome) Voltages() (float64, float64, float64, error) {
b, err := wb.conn.ReadHoldingRegisters(em2GoHomeRegVoltage1, 1)

if err != nil {
return 0, 0, 0, err
}

c, err := wb.conn.ReadHoldingRegisters(em2GoHomeRegVoltage2, 1)

if err != nil {
return 0, 0, 0, err
}

d, err := wb.conn.ReadHoldingRegisters(em2GoHomeRegVoltage3, 1)

if err != nil {
return 0, 0, 0, err
}
Expand Down

0 comments on commit 605b3b6

Please sign in to comment.