Add bundle endpoint client #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/x509" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/sirupsen/logrus" | ||
| "github.com/spiffe/spire/pkg/common/pemutil" | ||
| "github.com/spiffe/spire/pkg/server/bundle/client" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/kubernetes" | ||
| "k8s.io/client-go/rest" | ||
| ) | ||
|
|
||
| type BundleEndpointClientConfig struct { | ||
| TrustDomain string | ||
| EndpointAddress string | ||
| EndpointSpiffeID string | ||
|
|
||
| Namespace string | ||
| ConfigMapName string | ||
| ConfigMapKey string | ||
|
|
||
| Log logrus.FieldLogger | ||
| } | ||
|
|
||
| type BundleEndpointClient struct { | ||
| cfg *BundleEndpointClientConfig | ||
| kubeClient *kubernetes.Clientset | ||
| } | ||
|
|
||
| func StartBundleEndpointClient(ctx context.Context, cfg *BundleEndpointClientConfig) error { | ||
| kubeClient, err := newKubeClient() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| b := &BundleEndpointClient{ | ||
| cfg: cfg, | ||
| kubeClient: kubeClient, | ||
| } | ||
|
|
||
| go b.start(ctx) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) start(ctx context.Context) { | ||
| pollInterval := 5 * time.Minute | ||
| retryInterval := 5 * time.Second | ||
|
|
||
| var failing bool | ||
| ticker := time.NewTicker(pollInterval) | ||
| for { | ||
| select { | ||
| case <-ticker.C: | ||
| ok := b.trySync(ctx) | ||
|
|
||
| // Manipulate ticker frequency based on state changes | ||
| // between success and failure | ||
| if !ok && !failing { | ||
| failing = true | ||
| ticker = time.NewTicker(retryInterval) | ||
| } else if ok && failing { | ||
| failing = false | ||
| ticker = time.NewTicker(pollInterval) | ||
| } | ||
| case <-ctx.Done(): | ||
| return | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) trySync(ctx context.Context) bool { | ||
| roots, err := b.getEndpointRoots(ctx) | ||
| if err != nil { | ||
| b.cfg.Log.Errorf("Could not retrieve root CAs to validate bundle endpoint for %v: %v", b.cfg.TrustDomain, err) | ||
| return false | ||
| } | ||
|
|
||
| currentRoots, err := b.callBundleEndpoint(ctx, roots) | ||
| if err != nil { | ||
| b.cfg.Log.Errorf("Could not retrieve current root CAs from bundle endpoint for %v: %v", b.cfg.TrustDomain, err) | ||
| return false | ||
| } | ||
|
|
||
| err = b.updateRoots(ctx, roots, currentRoots) | ||
| if err != nil { | ||
| b.cfg.Log.Errorf("Could not persist root CA update for %v: %v", b.cfg.TrustDomain, err) | ||
| return false | ||
| } | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) getEndpointRoots(ctx context.Context) ([]*x509.Certificate, error) { | ||
| configMap, err := b.getConfigMap(ctx, b.cfg.Namespace, b.cfg.ConfigMapName) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| roots, err := pemutil.ParseCertificates([]byte(configMap.Data[b.cfg.ConfigMapKey])) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if len(roots) == 0 { | ||
| return nil, fmt.Errorf("no certs found") | ||
| } | ||
|
|
||
| return roots, nil | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) callBundleEndpoint(ctx context.Context, roots []*x509.Certificate) ([]*x509.Certificate, error) { | ||
| clientConfig := client.ClientConfig{ | ||
| TrustDomain: b.cfg.TrustDomain, | ||
| EndpointAddress: b.cfg.EndpointAddress, | ||
| EndpointSpiffeID: b.cfg.EndpointSpiffeID, | ||
| RootCAs: roots, | ||
| } | ||
| client := client.NewClient(clientConfig) | ||
|
|
||
| bundle, err := client.FetchBundle(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return bundle.RootCAs(), nil | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) updateRoots(ctx context.Context, roots, currentRoots []*x509.Certificate) error { | ||
| // TODO: Check if we need to actually update anything | ||
|
|
||
| configMap, err := b.getConfigMap(ctx, b.cfg.Namespace, b.cfg.ConfigMapName) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| pemBytes := pemutil.EncodeCertificates(currentRoots) | ||
| configMap.Data[b.cfg.ConfigMapKey] = string(pemBytes) | ||
|
|
||
| return b.updateConfigMap(ctx, b.cfg.Namespace, configMap) | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) getConfigMap(ctx context.Context, ns, name string) (*corev1.ConfigMap, error) { | ||
| return b.kubeClient.CoreV1().ConfigMaps(ns).Get(name, metav1.GetOptions{}) | ||
| } | ||
|
|
||
| func (b *BundleEndpointClient) updateConfigMap(ctx context.Context, ns string, configMap *corev1.ConfigMap) error { | ||
| _, err := b.kubeClient.CoreV1().ConfigMaps(ns).Update(configMap) | ||
| return err | ||
| } | ||
|
|
||
| func newKubeClient() (*kubernetes.Clientset, error) { | ||
| c, err := rest.InClusterConfig() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return kubernetes.NewForConfig(c) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be better, but we don't need it now :)