Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add defmt and add rust-version (MSRV) of 1.62 #29

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Jan 23, 2024

Something to note: defmt still uses bitflags@1 which adds some derive macros when bitflags! macro is used. defmt also defines their own bitflags! macro to derive Format which leads to the cfg_attributes when the defmt-03 feature is not enabled

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel elpiel mentioned this pull request Jan 23, 2024
1 task
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
Copy link
Contributor Author

elpiel commented Jan 24, 2024

@eupn should be ready for review. Had to tweak the CI and add the MSRV.

@elpiel
Copy link
Contributor Author

elpiel commented Jan 24, 2024

It seems that this feature was stabilized in 1.62 maybe we can bump the MSRV to that or even later version?

error[E0658]: deriving Default on enums is experimental
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/defmt-parser-0.3.3/src/types.rs:3:24
|
3 | #[derive(Clone, Debug, Default, Eq, PartialEq)]
| ^^^^^^^
|
= note: see issue #86985 rust-lang/rust#86985 for more information
= note: this error originates in the derive macro Default (in Nightly builds, run with -Z macro-backtrace for more info)

@eupn
Copy link
Owner

eupn commented Jan 24, 2024

It seems that this feature was stabilized in 1.62 maybe we can bump the MSRV to that or even later version?

Sure let's bump the MSRV.

@elpiel elpiel changed the title feat: add defmt and add rust-version (MSRV) of 1.60 feat: add defmt and add rust-version (MSRV) of 1.62 Jan 26, 2024
@elpiel
Copy link
Contributor Author

elpiel commented Jan 26, 2024

Pfff... Now it seems that nix requires bigger MSRV but it's only for the examples.

Maybe we can downgrade one of the dependencies to allow the examples to run on 1.62? It's a linux-embedded-hal dependency and that' our only option for embedded-hal@1.0 version of the crate

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@eupn eupn merged commit f450731 into eupn:master Jan 26, 2024
5 checks passed
@elpiel elpiel deleted the feat/defmt branch January 26, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants