Replace unweildy COMPILE_ASSERT macro with static_assert #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this codebase was originally written, there wasn't a built-in cross-compiler way to add compile-time asserts, so the original authors did something clever by forcing the compile-time instantiation of a undefined template class if a precondition was not met. However, this produces a wall of insane template errors all wrapped within macro expansions that is completely unintelligible if you haven't seen it before. Since C++11 we have static_assert for the same purpose, and can produce nice diagnostic strings as an added bonus :)
|
Old: New: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this codebase was originally written, there wasn't a built-in
cross-compiler way to add compile-time asserts, so the original
authors did something clever by forcing the compile-time
instantiation of a undefined template class if a precondition was
not met.
However, this produces a wall of insane template errors all wrapped
within macro expansions that is completely unintelligible if you
haven't seen it before.
Since C++11 we have static_assert for the same purpose, and can
produce nice diagnostic strings as an added bonus :)