Add grade counter and nothing as new tip types for Rebirth's footer #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure about the colorbygrade function possibly not working as intended and setting a default color instead of one defined in another color config preset, as I've noticed other places use ColorConfigChangedMessageCommand to redraw elements that are registered as color config actors.
Also, about ThemePrefs.lua -- it seems like that's for the main menu options, which aren't shown on Rebirth at all... And the strings that it pulled on lines 783 to 785 only seemed to be defined on Til' Death's en.ini, so I opted not to mess with that without a double-check first.
Both new options should work as intended through the cog menu, but it should be noted that all 5 grades show up regardless if a score with those grades was set or not.