Add support for inspect.iscoroutinefunction() for Coroutine provider #830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves Python 3.12+ support.
Background:
@asyncio.coroutine is no longer available since 3.11, asyncio.iscoroutinefunction() was a helper function to detect generator-based coroutines, i.e. functions marked with
@asyncio.coroutine
decorator, which set_is_coroutine
attribute. This implementation detail was historically abused to mark sync functions returning awaitables.Since 3.12, inspect.markcoroutinefunction() is a preferred way to mark sync functions returning awaitables. It is intended to be used with inspect.iscoroutinefunction(). Given the fact that we're in Cython realm, we have to resort to less graceful solution and go deeper by abusing implementation details, again.
Note:
asyncio.iscoroutinefunction()
will be deprecated in 3.16, so old marker is still in place for better compatibility.