Use Django's system check instead of a log warning #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows silencing the warning in case the user knows what they are doing. The check for AWS_S3_BUCKET_NAME is left untouched because it looks like even checks of level ERROR or CRITICAL can be silenced. Raising an exception seems like the better option to me. Closes #153.
|
Ah, this is more complex than I thought. Really, this check needs to be a part of the storage class, since we need to check both the static file storage and the file storage classes, as well as any additional storage classes that the user might manually create. I implemented this approach in #156, using your code as a starting point. However, Django instantiates the default file storage (and the default staticfiles storage), lazily. Meaning the per-storage checks implemented in #157 don't fire. The proper solution is probably the one in #157, but to actually get these checks to fire, we'd need to eagerly instantiate the default file storages, which would be suprising behavior to users. Thoughts, @jnns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks applied on top of #156.
Closes #153
Closes #156