Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray casting-based depth image renderer #81

Merged

Conversation

Divelix
Copy link
Contributor

@Divelix Divelix commented Oct 21, 2024

Discussed in #80

This PR adds functionality of depth map extraction from wavemap octree at any pose and camera intrinsics.

I also added python bindings for:

  • PinholeCameraProjectorConfig - I use it to store camera intrinsics on python side
  • raycast - allows to cast ray between 2 points and get distance to closest occupied leaf
  • get_depth - uses raycast for all pixels in depth map (utilizes QueryAccelerator for faster processing)

Moreover, I added corresponding python script to examples folder (I used pathlib instead of os.path because it is considered better practice in python).

@victorreijgwart victorreijgwart changed the title Depth extraction Ray casting-based depth/range image renderer Oct 24, 2024
@victorreijgwart victorreijgwart changed the title Ray casting-based depth/range image renderer Ray casting-based depth image renderer Oct 24, 2024
@victorreijgwart victorreijgwart changed the base branch from main to feature/depth_image_renderer November 18, 2024 15:12
@victorreijgwart
Copy link
Member

victorreijgwart commented Nov 18, 2024

Thank you, @Divelix, for this PR! This feature will be useful for many applications, and I'm looking forward to including it in an upcoming release. Here's the plan for the next two weeks:

  • Import the branch from your fork into the main repo so that we can run it through all CI pipelines (similarly to Fix Mypy error #79)
  • Move the core functionality into the C++ library to ensure the feature is available in both C++ and Python
  • Extend the implementation to support all projection models in wavemap (pinhole cameras, standard LiDARs, and Ouster LiDARs)
  • Add unit tests to ensure correctness and so that our CI pipeline can check that there is no undefined behavior

In parallel, we're preparing another PR to extend the QueryAccelerator to work with HashedChunkedWaveletOctrees. We'll complete that first so that this depth renderer can be released with full support for all commonly used map types.

@victorreijgwart victorreijgwart merged commit b342a2f into ethz-asl:feature/depth_image_renderer Nov 18, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants