Skip to content

Commit

Permalink
Merge pull request #187 from ethpandaops/pk910/dependency-fix
Browse files Browse the repository at this point in the history
fix dependency for ui-package
  • Loading branch information
pk910 authored Dec 6, 2024
2 parents f567bd2 + 23d46d2 commit 45351a7
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 5 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/_shared-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,15 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20.x
cache: 'npm'
cache-dependency-path: ./ui-package/package-lock.json
- name: Cache node-modules for UI package
id: cache-npm
uses: actions/cache@v3
with:
path: ./ui-package/node_modules
key: uipackage-npm-${{ runner.os }}-${{ hashFiles('./ui-package/package-lock.json') }}
restore-keys: |
uipackage-npm-${{ runner.os }}-
uipackage-npm-
# build UI package
- name: Build UI package
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/_shared-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,19 @@ jobs:
uses: actions/setup-go@v4
with:
go-version: 1.22.x
- name: Set up node
uses: actions/setup-node@v4
with:
node-version: 20.x
- name: Cache node-modules for UI package
id: cache-npm
uses: actions/cache@v3
with:
path: ./ui-package/node_modules
key: uipackage-npm-${{ runner.os }}-${{ hashFiles('./ui-package/package-lock.json') }}
restore-keys: |
uipackage-npm-${{ runner.os }}-
uipackage-npm-
- name: Prepare test environment
run: mkdir -p ui-package/dist && touch ui-package/dist/dummy
Expand All @@ -41,3 +54,10 @@ jobs:

- name: Run tests
run: go test -race -vet=off ./...


# build UI package
- name: Build UI package
run: |
make build-ui
20 changes: 17 additions & 3 deletions ui-package/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ui-package/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"@babel/core": "^7.25.2",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-object-rest-spread": "^7.20.7",
"@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/preset-env": "^7.25.3",
"@babel/preset-flow": "^7.24.7",
"@babel/preset-react": "^7.24.7",
Expand Down

0 comments on commit 45351a7

Please sign in to comment.