Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The comments in the title block of SI5351.set_freq(freq, clk) say freq units are Hz. I think they are Hz*100ULL. #97

Open
frohro opened this issue Apr 6, 2024 · 3 comments

Comments

@frohro
Copy link

frohro commented Apr 6, 2024

This is on line 180 of si5351.cpp. I believe the same issues occur with SI5351.set_freq_manual and probably other functions should be checked. This is important as VScode and other IDEs display those comments when you hover over the function call.

@NT7S
Copy link
Member

NT7S commented Apr 9, 2024

Thank you, I'll fix this in the next update, which shouldn't be too long now that I've got a lab again.

@frohro
Copy link
Author

frohro commented Apr 9, 2024

Thanks!

@conr2286
Copy link
Contributor

conr2286 commented Dec 5, 2024

I've bumped into this one too and just changed the comment re. set_freq() params in my clone. It was a puzzle for a moment as I was sure the dividers must be set wrong. 🙃

Let me know if u want a pull; I'll make the fix on a clean fork (you don't want the hacked-up bits I use;).

JimC, KQ7B

conr2286 added a commit to conr2286/Si5351Arduino that referenced this issue Dec 5, 2024
… in 0.01 Hz

Fix comments for set_freq() and set_freq_manual() to indicate that frequency parameters are specified in 0.01 Hz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants