Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation: don't copy memory in proof deserialization #176

Open
gballet opened this issue Jan 17, 2022 · 0 comments
Open

Optimisation: don't copy memory in proof deserialization #176

gballet opened this issue Jan 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@gballet
Copy link
Member

gballet commented Jan 17, 2022

The issue is explained in this comment:

https://github.com/gballet/go-verkle/pull/175/files#r784676273

This optimization assumes that the buffer won't be reused at a later stage. Because the go-ethereum part of the code is still very much work in progress, we decided to go for the slower, safer route and copy the data. To be revisited when the API becomes more stable.

@gballet gballet added the enhancement New feature or request label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant