Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reentrancy protection with optional parameter #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reentrancy protection with optional parameter #3

wants to merge 1 commit into from

Conversation

ShubhSensei
Copy link

#1

Reentrancy Protection

  • The child class cannot inherit the TransientReentrancyAware contract's modifier automatically.
  • Thus made a new modifier in the TransientContext contract itself.
  • The bytes32 key in the modifier is used to create separate locks, which do not interfere with each other to ensure atomic access.

@0xfuturistic
Copy link
Contributor

could we add tests for this @ShubhSensei?

@pegahcarter
Copy link

ping @ShubhSensei

@0xfuturistic
Copy link
Contributor

@pegahcarter would you like to give it a shot? you can make a new PR extending this one and adding tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhSensei @0xfuturistic @pegahcarter