Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #9

Open
bitdaddy89 opened this issue Dec 6, 2023 · 0 comments
Open

review #9

bitdaddy89 opened this issue Dec 6, 2023 · 0 comments
Assignees

Comments

@bitdaddy89
Copy link

NFT_market_contract.sol
L96 unused,
L124 reduce the cal of Hash
L125 check the returned success1 value to determine if continue or not (and what the 1 stands for ?)
L184 cal Hash after the expiration checked passed
L209 isOrderInvalid
L230: 1. impossible case, 2. both event for success and fail would be triggered
L416: just transfer 721 is not 'atomic', do both side (transfer money to seller)

  • since this is a public function, have to check expiration here, otherwise the expiration would be useless
    L463 check seller with owner, don't want to record other user's info
    price of ERC20 and ETD should be distinguished
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants