Only retry idempotent operations by default. Fixes #1444

[jcferretti]

See description on #1444

[jcferretti]

Note the PR is also renaming a test case,
public void testAuthErrorIsNotRetryable()
to
public void testAuthErrorIsRetryable()
in trying to correctly reflect what the test is actually doing (the test was, and still is, checking that the error is retryable)

[lburgazzoli]

@jcferretti thx a lot for the PR, wonder if the autoRetry flag could be added to the related *Option object, instead of an additional method argument.

[jcferretti]

@jcferretti thx a lot for the PR, wonder if the autoRetry flag could be added to the related *Option object, instead of an additional method argument.

You are welcome, thanks for the quick followup.

Good call on putting autoRetry behind Option objects, much better, less interface pollution. Done!

[jcferretti]

I used the chance to add a few more javadoc comments to other options, eg,

    /**
     * Only populate results for keys that match a
     * minimum value for a created revision.
     *
     * Note this filter does not affect the Count field in GetResponse.
     * Count always counts the number of keys matched on a range, independent of other filters.
     *
     * @return minimum created revision to match, or zero for any.
     */
    public long getMinCreateRevision() {
        return this.minCreateRevision;
    }

The semantics of count not matching requested filters bit me in the past: etcd-io/etcd#18267
I am trying to help prevent it biting others in the future.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcferretti, lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lburgazzoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcferretti]

@lburgazzoli thank you very much for the quick turnaround. Any chance there will be a new minor release including this in the medium term? My team would like to pick it up for our system once available. Not immediately urgent for us, but since it impacts reliability, it would be nice to have some understanding/visibility for when.

[lburgazzoli]

hope before of end of the week