Migrate --experimental-set-member-localaddr to using feature flag

[henrybear327]

Reference: #18023 (comment)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[henrybear327]

@ahrtr I am not sure how to update

etcd/CHANGELOG/CHANGELOG-3.6.md

Line 81 in 3bd966d

- Add ['etcd --experimental-set-member-localaddr'](https://github.com/etcd-io/etcd/pull/17661) to enable using the first specified and non-loopback local address from initial-advertise-peer-urls as the local address when communicating with a peer.

[henrybear327]

Fixing the unit test now.

[ahrtr]

@ahrtr I am not sure how to update

etcd/CHANGELOG/CHANGELOG-3.6.md

Line 81 in 3bd966d

- Add ['etcd --experimental-set-member-localaddr'](https://github.com/etcd-io/etcd/pull/17661) to enable using the first specified and non-loopback local address from initial-advertise-peer-urls as the local address when communicating with a peer.

We can change it to something like below,

Add feature gate 'SetMemberLocalAddr' to enable using the first specified and non-loopback local address from initial-advertise-peer-urls as the local address when communicating with a peer

[henrybear327]

Unit tests are updated because of #19413 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (3bd966d) to head (5fa8c1f).
Report is 4 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/config.go	80.08% <100.00%> (-0.03%)	⬇️
server/embed/etcd.go	76.32% <ø> (-0.05%)	⬇️
server/features/etcd_features.go	60.00% <ø> (ø)

... and 26 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19413   +/-   ##
=======================================
  Coverage   68.95%   68.95%           
=======================================
  Files         420      420           
  Lines       35755    35753    -2     
=======================================
- Hits        24656    24655    -1     
- Misses       9677     9680    +3     
+ Partials     1422     1418    -4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd966d...5fa8c1f. Read the comment docs.

[ahrtr]

LGTM with a couple of minor comments.

cc. @fuweid @ivanvc @siyuanfoundation

[henrybear327]

Comments are all addressed.

Thank you @ahrtr for reviewing this throughout the day!

[ahrtr]

cc @fuweid @ivanvc @siyuanfoundation @serathius

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, henrybear327

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahrtr]

/cherry-pick release-3.6

[k8s-infra-cherrypick-robot]

@ahrtr: new pull request created: #19414

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.