Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a performance regression due to uncertain compaction sleep interval #19410

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 13, 2025

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr changed the title Fix a peformance regression due to uncertain compaction sleep interval Fix a performance regression due to uncertain compaction sleep interval Feb 13, 2025
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (075fb10) to head (de10fd6).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/kvstore_compaction.go 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19410      +/-   ##
==========================================
- Coverage   68.92%   68.91%   -0.01%     
==========================================
  Files         420      420              
  Lines       35757    35755       -2     
==========================================
- Hits        24645    24641       -4     
- Misses       9690     9694       +4     
+ Partials     1422     1420       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075fb10...de10fd6. Read the comment docs.

@ahrtr ahrtr merged commit 3bd966d into etcd-io:main Feb 13, 2025
38 checks passed
@ahrtr
Copy link
Member Author

ahrtr commented Feb 13, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19411

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Performance regression in etcd v3.5.16
4 participants