-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more v3.6 deprecation comments #19408
Conversation
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19408 +/- ##
=======================================
Coverage 68.93% 68.94%
=======================================
Files 420 420
Lines 35757 35757
=======================================
+ Hits 24649 24652 +3
- Misses 9683 9684 +1
+ Partials 1425 1421 -4 Continue to review full report in Codecov by Sentry.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.6 |
@ahrtr: new pull request created: #19409 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I did the fixing of the remaining deprecated experimental options:
ExperimentalTxnModeWriteWithSharedBuffer
ExperimentalStopGRPCServiceOnDefrag
ExperimentalInitialCorruptCheck
And also standardized all deprecation messages in
server/etcdmain/help.go
Part of #18023
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.