Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more v3.6 deprecation comments #19408

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 13, 2025

I did the fixing of the remaining deprecated experimental options:

  • ExperimentalTxnModeWriteWithSharedBuffer
  • ExperimentalStopGRPCServiceOnDefrag
  • ExperimentalInitialCorruptCheck

And also standardized all deprecation messages in server/etcdmain/help.go

Part of #18023

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.94%. Comparing base (7073c41) to head (9c30af2).
Report is 5 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <ø> (ø)
server/embed/config.go 80.11% <ø> (ø)

... and 20 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19408   +/-   ##
=======================================
  Coverage   68.93%   68.94%           
=======================================
  Files         420      420           
  Lines       35757    35757           
=======================================
+ Hits        24649    24652    +3     
- Misses       9683     9684    +1     
+ Partials     1425     1421    -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7073c41...9c30af2. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Feb 13, 2025

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b77a28c into etcd-io:main Feb 13, 2025
37 checks passed
@ahrtr
Copy link
Member

ahrtr commented Feb 13, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19409

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the more-v3.6-deprecation-comments branch February 13, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants