-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.6] server: Remove deprecated NewZapCoreLoggerBuilder #19404
[release-3.6] server: Remove deprecated NewZapCoreLoggerBuilder #19404
Conversation
Signed-off-by: Ivan Valdes <ivan@vald.es>
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #19404 +/- ##
============================================
Coverage 68.92% 68.93%
============================================
Files 420 420
Lines 35759 35757 -2
============================================
Hits 24648 24648
+ Misses 9692 9685 -7
- Partials 1419 1424 +5 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ivan Valdes <ivan@vald.es>
CHANGELOG-3.6: Add note from #19404
This is an automated cherry-pick of #19403
/assign ahrtr