Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.6] server: Remove deprecated NewZapCoreLoggerBuilder #19404

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #19403

/assign ahrtr

Signed-off-by: Ivan Valdes <ivan@vald.es>
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Feb 12, 2025

/ok-to-test

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (2feb5a2) to head (f1095ba).
Report is 2 commits behind head on release-3.6.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config_logging.go 52.17% <ø> (+0.64%) ⬆️

... and 22 files with indirect coverage changes

@@             Coverage Diff              @@
##           release-3.6   #19404   +/-   ##
============================================
  Coverage        68.92%   68.93%           
============================================
  Files              420      420           
  Lines            35759    35757    -2     
============================================
  Hits             24648    24648           
+ Misses            9692     9685    -7     
- Partials          1419     1424    +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2feb5a2...f1095ba. Read the comment docs.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ivanvc added a commit to ivanvc/etcd that referenced this pull request Feb 13, 2025
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ahrtr ahrtr merged commit 34afaca into etcd-io:release-3.6 Feb 13, 2025
34 checks passed
ahrtr added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants