Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate experimental-downgrade-checktime to downgrade-checktime #19328

Merged

Conversation

ajaysundark
Copy link
Contributor

@ajaysundark ajaysundark commented Feb 4, 2025

Migrate flag experimental-downgrade-check-time to downgrade-check-time.

Sub task from #19141

@k8s-ci-robot
Copy link

Hi @ajaysundark. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ajaysundark
Copy link
Contributor Author

/cc @siyuanfoundation @gangli113

@k8s-ci-robot
Copy link

@ajaysundark: GitHub didn't allow me to request PR reviews from the following users: gangli113.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @siyuanfoundation @gangli113

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (e13196b) to head (80a8a82).
Report is 23 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.75% <100.00%> (+0.03%) ⬆️
server/embed/etcd.go 76.45% <100.00%> (-0.35%) ⬇️
server/etcdmain/config.go 73.80% <100.00%> (+0.31%) ⬆️

... and 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19328      +/-   ##
==========================================
+ Coverage   68.88%   68.91%   +0.02%     
==========================================
  Files         420      420              
  Lines       35706    35720      +14     
==========================================
+ Hits        24596    24616      +20     
+ Misses       9687     9675      -12     
- Partials     1423     1429       +6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13196b...80a8a82. Read the comment docs.

@siyuanfoundation
Copy link
Contributor

/ok-to-test

@siyuanfoundation
Copy link
Contributor

/retest

@siyuanfoundation
Copy link
Contributor

/lgtm
Thanks @ajaysundark for your first PR!

Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
@ajaysundark ajaysundark force-pushed the migrate-experimental-downgrade-check-time branch from fc3d2ad to 80a8a82 Compare February 6, 2025 00:05
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 6, 2025
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ajaysundark, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 299bca3 into etcd-io:main Feb 6, 2025
37 checks passed
@ajaysundark ajaysundark deleted the migrate-experimental-downgrade-check-time branch February 11, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants