-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate experimental-downgrade-checktime to downgrade-checktime #19328
migrate experimental-downgrade-checktime to downgrade-checktime #19328
Conversation
Hi @ajaysundark. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ajaysundark: GitHub didn't allow me to request PR reviews from the following users: gangli113. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 27 files with indirect coverage changes @@ Coverage Diff @@
## main #19328 +/- ##
==========================================
+ Coverage 68.88% 68.91% +0.02%
==========================================
Files 420 420
Lines 35706 35720 +14
==========================================
+ Hits 24596 24616 +20
+ Misses 9687 9675 -12
- Partials 1423 1429 +6 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
1aaa4a0
to
fc3d2ad
Compare
/retest |
/lgtm |
Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
fc3d2ad
to
80a8a82
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ajaysundark, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Migrate flag
experimental-downgrade-check-time
todowngrade-check-time
.Sub task from #19141