Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add learner check to readyz #19280

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

gojoy
Copy link
Contributor

@gojoy gojoy commented Jan 27, 2025

Backport #19086
Fix #19001

Signed-off-by: GitHub <noreply@github.com>
@k8s-ci-robot
Copy link

Hi @gojoy. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gojoy
Copy link
Contributor Author

gojoy commented Jan 27, 2025

/retest-required

@k8s-ci-robot
Copy link

@gojoy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gojoy
Copy link
Contributor Author

gojoy commented Jan 27, 2025

@ahrtr Hi .This request need /ok-to-test.Thanks

@ahrtr
Copy link
Member

ahrtr commented Jan 27, 2025

/ok-to-test

@gojoy
Copy link
Contributor Author

gojoy commented Jan 27, 2025

/retest-required

1 similar comment
@gojoy
Copy link
Contributor Author

gojoy commented Jan 27, 2025

/retest-required

@gojoy
Copy link
Contributor Author

gojoy commented Jan 27, 2025

@k8s-ci-robot /retest-required

@gojoy
Copy link
Contributor Author

gojoy commented Jan 28, 2025

/ok-to-test

I can't trigger retest-required. Can you help me, Thanks @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Jan 28, 2025

/retest

@siyuanfoundation
Copy link
Contributor

/lgtm
Thanks @gojoy for backporting this!

@ahrtr
Copy link
Member

ahrtr commented Jan 28, 2025

We need to add a changelog itme as well. cc @gojoy @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

THanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, gojoy, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 030e361 into etcd-io:release-3.5 Jan 28, 2025
28 checks passed
@ivanvc
Copy link
Member

ivanvc commented Jan 30, 2025

@gojoy, can you update the 3.5 CHANGELOG?

@gojoy
Copy link
Contributor Author

gojoy commented Jan 30, 2025

@gojoy, can you update the 3.5 CHANGELOG?

OK.I'll finish this after my vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants