-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to use memory-mlock flag #19277
Conversation
Hi @jmao-dd. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## main #19277 +/- ##
==========================================
- Coverage 68.86% 68.79% -0.08%
==========================================
Files 420 420
Lines 35680 35684 +4
==========================================
- Hits 24571 24548 -23
- Misses 9684 9716 +32
+ Partials 1425 1420 -5 Continue to review full report in Codecov by Sentry.
|
bf39955
to
e7185d1
Compare
server/etcdmain/help.go
Outdated
@@ -75,6 +75,8 @@ Member: | |||
Maximum number of snapshot files to retain (0 is unlimited). Deprecated in v3.6 and will be decommissioned in v3.7. | |||
--max-wals '` + strconv.Itoa(embed.DefaultMaxWALs) + `' | |||
Maximum number of wal files to retain (0 is unlimited). | |||
--memory-mlock | |||
Enable to enforce etcd pages (in particular bbolt) to stay in RAM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if Member
is the right category for this flag. If there is a better place I will move it.
/retest |
b795fed
to
8024273
Compare
50ecfac
to
e757a45
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmao-dd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Somehow I messed up branch history again. Opened a new PR #19282 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This is for #19061