Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to use memory-mlock flag #19277

Closed
wants to merge 0 commits into from

Conversation

jmao-dd
Copy link
Contributor

@jmao-dd jmao-dd commented Jan 26, 2025

@k8s-ci-robot
Copy link

Hi @jmao-dd. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jan 26, 2025

/ok-to-test

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (e757a45) to head (50ecfac).

Current head 50ecfac differs from pull request most recent head e757a45

Please upload reports for the commit e757a45 to get more accurate results.

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <ø> (ø)
server/embed/config.go 79.65% <100.00%> (+0.06%) ⬆️
server/embed/etcd.go 76.49% <100.00%> (ø)
server/etcdmain/config.go 73.17% <100.00%> (+0.33%) ⬆️
server/storage/backend.go 72.72% <100.00%> (ø)

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19277      +/-   ##
==========================================
- Coverage   68.86%   68.79%   -0.08%     
==========================================
  Files         420      420              
  Lines       35680    35684       +4     
==========================================
- Hits        24571    24548      -23     
- Misses       9684     9716      +32     
+ Partials     1425     1420       -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e757a45...e757a45. Read the comment docs.

@jmao-dd jmao-dd force-pushed the jmao/19061-migrate-mlock2 branch from bf39955 to e7185d1 Compare January 26, 2025 23:19
@@ -75,6 +75,8 @@ Member:
Maximum number of snapshot files to retain (0 is unlimited). Deprecated in v3.6 and will be decommissioned in v3.7.
--max-wals '` + strconv.Itoa(embed.DefaultMaxWALs) + `'
Maximum number of wal files to retain (0 is unlimited).
--memory-mlock
Enable to enforce etcd pages (in particular bbolt) to stay in RAM.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if Member is the right category for this flag. If there is a better place I will move it.

@jmao-dd
Copy link
Contributor Author

jmao-dd commented Jan 27, 2025

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmao-dd

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmao-dd
Copy link
Contributor Author

jmao-dd commented Jan 27, 2025

Somehow I messed up branch history again. Opened a new PR #19282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants