-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Solution 2] Add DowngradeVersionTestRequest
for Downgrade or migration test only
#19276
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19276 +/- ##
==========================================
+ Coverage 68.81% 68.93% +0.12%
==========================================
Files 420 420
Lines 35680 35689 +9
==========================================
+ Hits 24552 24602 +50
+ Misses 9702 9672 -30
+ Partials 1426 1415 -11 Continue to review full report in Codecov by Sentry.
|
c53dca0
to
2f42c25
Compare
cc @fuweid @serathius @siyuanfoundation This PR might be a little better than #19274 |
…est purpose only Executed both scripts below, - ./scripts/genproto.sh - ./scripts/update_proto_annotations.sh Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2f42c25
to
f0d6dec
Compare
Executed both scripts below again, - ./scripts/genproto.sh - ./scripts/update_proto_annotations.sh Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
…sion Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
f0d6dec
to
7b4b96d
Compare
The solution 1 #19274 changes the protoc between client and server, so I prefer to this PR (solution 2). See my summary in #19274 (comment) |
@fuweid @siyuanfoundation @serathius this is one of the blockers to cut release-3.6, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks both @fuweid and @siyuanfoundation for the quick review! |
Link to #19274
Please review this PR commit by commit, it should be super clear and straightforward.