Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solution 2] Add DowngradeVersionTestRequest for Downgrade or migration test only #19276

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 26, 2025

Link to #19274

Please review this PR commit by commit, it should be super clear and straightforward.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (f7a36a5) to head (7b4b96d).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
server/storage/wal/version.go 42.85% 2 Missing and 2 partials ⚠️
server/etcdserver/server.go 33.33% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/server.go 82.00% <33.33%> (-0.28%) ⬇️
server/storage/wal/version.go 51.53% <42.85%> (-0.39%) ⬇️

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19276      +/-   ##
==========================================
+ Coverage   68.81%   68.93%   +0.12%     
==========================================
  Files         420      420              
  Lines       35680    35689       +9     
==========================================
+ Hits        24552    24602      +50     
+ Misses       9702     9672      -30     
+ Partials     1426     1415      -11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a36a5...7b4b96d. Read the comment docs.

@ahrtr ahrtr force-pushed the downgrad_test_20250126 branch from c53dca0 to 2f42c25 Compare January 26, 2025 09:41
@ahrtr
Copy link
Member Author

ahrtr commented Jan 26, 2025

cc @fuweid @serathius @siyuanfoundation This PR might be a little better than #19274

…est purpose only

Executed both scripts below,
- ./scripts/genproto.sh
- ./scripts/update_proto_annotations.sh

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the downgrad_test_20250126 branch from 2f42c25 to f0d6dec Compare January 27, 2025 09:40
ahrtr added 4 commits January 27, 2025 09:52
Executed both scripts below again,
- ./scripts/genproto.sh
- ./scripts/update_proto_annotations.sh

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
…sion

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the downgrad_test_20250126 branch from f0d6dec to 7b4b96d Compare January 27, 2025 09:52
@ahrtr
Copy link
Member Author

ahrtr commented Jan 27, 2025

The solution 1 #19274 changes the protoc between client and server, so I prefer to this PR (solution 2). See my summary in #19274 (comment)

cc @fuweid @siyuanfoundation @serathius

@ahrtr
Copy link
Member Author

ahrtr commented Jan 27, 2025

@fuweid @siyuanfoundation @serathius this is one of the blockers to cut release-3.6, PTAL

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Jan 27, 2025

Thanks both @fuweid and @siyuanfoundation for the quick review!

@ahrtr ahrtr merged commit ee32f70 into etcd-io:main Jan 27, 2025
34 checks passed
@ahrtr ahrtr deleted the downgrad_test_20250126 branch January 27, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants